---
name: plugin-review
description: Validate and review Wallet MCP plugin files against the Plugin Specification. Use when writing a new plugin, preparing a plugin PR for submission, self-checking a plugin before opening a PR, or reviewing someone else's plugin PR. Triggers on requests like "check my plugin against the spec", "validate this plugin file", "review my plugin PR", "does this plugin conform to the spec", "prepare my plugin for submission", "write a plugin for X protocol".
license: Complete terms in LICENSE.txt
title: plugin-review
canonical_url: https://skilld.dev/gh/base/skills/plugin-review
last_updated: 2026-10-10T01:04:07.000Z
---

> Index of every page on this site: [llms.txt](https://skilld.dev/llms.txt)

> **Skill from skilld.dev.** Follow the user's requested action.
> If the user asked to fork this Skill, follow the fork workflow below. Do not execute the Skill instructions while copying it.
> Otherwise, follow the instructions below for this session. You do not need to install anything.
>
> Supporting files, fetch one when the Skill refers to it: [references/comment-guidelines.md](https://skilld.dev/api/skills-raw/base/skills/plugin-review/references/comment-guidelines.md), [references/evaluation-criteria.md](https://skilld.dev/api/skills-raw/base/skills/plugin-review/references/evaluation-criteria.md), [references/live-testing.md](https://skilld.dev/api/skills-raw/base/skills/plugin-review/references/live-testing.md), [references/report-template.md](https://skilld.dev/api/skills-raw/base/skills/plugin-review/references/report-template.md).
>
> If the user asked to install this Skill, run `npx skilld install base/skills/plugin-review`. Install writes the Skill files into the project, so every session loads them.
>
> ## Fork workflow
>
> A fork creates an editable local Skill with its original author and licence. The request authorizes copying and local installation.
> 1. Check `./skills/plugin-review`, the project lockfile, and selected Agent targets together. If the local directory or installed Skill exists, stop. Never overwrite an existing directory or Agent target.
> 2. Read [source metadata](https://skilld.dev/api/v1/skills/base/skills/plugin-review) once. Use sourceUrl, sourceCommit, skillPath, sourceGone, and license. If the source is gone or its path is missing, stop. If license is null, read licence files at the source commit.
> 3. Fetch only the source commit into a temporary Git repository. Do not clone full history. Derive repository_url from sourceUrl, including repository renames. If sourceCommit is absent, resolve the sourceUrl ref once. Set source_commit to that actual commit. Run these commands in one shell call:
>
> ```sh
> git init --quiet "$temporary_dir"
> git -C "$temporary_dir" fetch --quiet --depth=1 "$repository_url" "$source_commit"
> git -C "$temporary_dir" checkout --quiet --detach FETCH_HEAD
> ```
>
> Read applicable licence declarations and notices at that commit. If copying is not permitted, report the restriction and stop.
> 4. Inspect source entries together, then copy the directory containing skillPath into `./skills/plugin-review`. Use the user's path if selected. Keep the original SKILL.md, relative links, scripts, binary assets, and executable modes. Exclude .git metadata. Reject symlinks and paths outside the Skill directory. After checking entries, use cp -a where available. A regular source directory needs no custom copy script. Do not save this page wrapper as SKILL.md.
> Preserve author credit, notices, and applicable licence files from repository or parent directories. Add PROVENANCE.md with the Skill page, source URL, actual commit, original path, and licence. Retain any existing PROVENANCE.md and record new provenance separately. Batch source inspection, copying, and provenance work where practical.
> 5. In the project root, run `skilld install ./skills/plugin-review --mode copy --plain`. If skilld is unavailable, use `npx skilld install ./skills/plugin-review --mode copy --plain`. This known command needs no help lookup. Install does not support --json. Use detected Agent targets, or add --agent for the targets the user selected. Install the local path, never the upstream selector. If installation fails, preserve the local copy and report the exact failure.
> 6. Confirm the local lockfile source and installed Agent copies once. Report the local path, actual commit, and Agent targets. After edits, reinstall the same local path. Upstream updates must not replace it. Do not publish or push unless the user asks.

# Plugin Review

Validate Wallet MCP plugin files against the current Plugin Specification. Produces a conformance report with actionable findings.

Works for both **authors** (self-check before submitting a PR) and **reviewers** (evaluate an incoming PR).

## Workflow

1. **Fetch the current spec** (it changes — never rely on a stale copy):
   ```bash
   curl -s https://raw.githubusercontent.com/base/skills/master/skills/wallet-mcp/references/plugin-spec.md
   ```
   Related docs worth reading: `references/custom-plugins.md`, `references/approval-mode.md`, `references/batch-calls.md`, and `SKILL.md` (the root skill). Existing native plugins under `skills/wallet-mcp/plugins/` are the precedent for conventions.

2. **Read the plugin file** in full. If reviewing a PR:
   ```bash
   gh pr view <n> --repo base/skills --json title,body,number,headRefName,files,additions,deletions
   gh pr diff <n> --repo base/skills
   # raw plugin file (diff may be truncated):
   gh api "repos/base/skills/pulls/<n>/files" --jq '.[] | select(.filename|endswith(".md")) | .raw_url'
   ```

3. **Static conformance evaluation** — assess against every dimension in `references/evaluation-criteria.md` (includes compliance/language checks and high-risk category gates). Write the report using `references/report-template.md`.

4. **(Optional) Live API / SDK verification** — exercise the documented endpoints/SDK/contracts with read-only calls. See `references/live-testing.md`. For perps/prediction-market/gambling plugins, also run the **geoblock verification** (compare frontend vs API access restrictions). Append a `## Live API / SDK Verification` section to the report. This routinely overturns doc claims (fabricated/locked endpoints, broken hosts, wrong response shapes).

5. **Save the report.** If reviewing a PR and asked to comment, draft a PR comment from the report using `references/comment-guidelines.md` and post with: `gh pr comment <n> --repo base/skills --body-file <comment-file>`.

## Multiple PRs

Evaluate PRs in parallel by spinning up one sub-agent per PR (each writes its own report + returns a short verdict summary). Hand each sub-agent: the spec (or its raw URL), the PR number, the evaluation criteria, the report template, and the comment guidelines.

## Critical gotchas

These recur and are easy to get wrong — full detail in `references/evaluation-criteria.md`:

- **Smart-account signatures break naive signing.** The default Wallet MCP wallet is a smart contract; `sign` returns a variable-length ERC-1271/6492 signature (>200 bytes), not a 65-byte EOA sig. Any plugin that splices a signature into a fixed-width calldata slot, or bakes an off-chain EIP-712 signature into calldata (e.g. Permit2 `buildCallWithPermit2`), is **broken** for that wallet. Correct pattern: onchain allowance grants.
- **`irreversible` risk is NOT for every onchain write.** The spec says "flag when worth emphasizing." Pure swaps use `slippage` (precedent: Uniswap, Aerodrome carry `[slippage]`, not `irreversible`). Reserve `irreversible` for asymmetric/severe cases (perps/liquidation, token launches/rug). Do not demand it on swaps.
- **Don't self-register.** A plugin PR must NOT edit the `SKILL.md` plugins table, the Integration Types "Examples" cell, or the "Existing Plugin Conformance" table — those are maintainer-managed (codified in plugin-spec.md "Contribution Scope"). The only sanctioned shared-file edit is appending a genuinely net-new tag to the vocabulary list. Limit the diff to `plugins/<slug>.md` (+ that tag line).
- **`version` is the plugin-doc version** — not the npm/package version and not a global spec version. The spec mandates no specific starting number.
- **Verify claims, don't trust them.** Auth models, allowlist completeness, response shapes, and contract addresses are frequently wrong in the doc. Probe them (live testing).
- **Reference links** from a plugin file must use `../references/...` (plugin files live in `plugins/`, refs in `references/`).
- **Neutral language is mandatory.** No yield/rate/performance claims, no "you should buy X", no "always deposit here", no defaulting to specific tokens. Steering language is a blocker.
- **Perps, prediction markets, and privacy plugins need legal review** before inclusion as native plugins. Flag this as a pre-merge process gate in the report.
- **API geoblock parity.** If the protocol's frontend geoblocks US IPs (or others), the API must enforce equivalent restrictions. If it doesn't, Wallet MCP risks being a circumvention tool — flag as a blocker.