All skills
macro-inc avatar
by Macromacro-inc/macro4.5k stars
435

Quality gate. 5 parallel agents review changes. All must pass.

  • 1 file
  • 2.3 KB
  • Updated 8 months ago
  • GitHub

Use this Skill: https://skilld.dev/gh/macro-inc/macro/qc

This session only. Nothing lands on disk.

SKILL.md

โ‰ˆ17 tokens always: the name and description. โ‰ˆ551 when used: this file.

QC Gate

Setup

DIFF=$(git diff main)
FILES=$(git diff main --name-only)
TASK="{task description or 'general changes'}"

Read 1-2 unmodified files from same directories for pattern context.

Agents

Spawn all 5 in parallel. All output raw JSON only, no markdown.

1: Code Review (sonnet)

DIFF: ${DIFF}

- Descriptive naming?
- Errors caught with useful messages?
- No hardcoded values, commented code, debug statements?
- No TODO without ticket ref?
- No obvious bugs?
- No useless comments?

{"pass": bool, "issues": [...]}

2: Simplification (sonnet)

DIFF: ${DIFF}

- Is this overcomplicated? Can I solve the same problem in a simpler manner?
- Can I reduce indirection?
- Can I reduce surface area?
- Premature abstraction? Premature Optimization? YAGNI violations?
- Dead code?
- Three similar lines > one abstraction

{"pass": bool, "issues": [...]}

3: Consistency (sonnet)

DIFF: ${DIFF}
PATTERNS: ${PATTERN_FILES}

- Matches existing codebase patterns?
- Proper types, no any, no unsafe casts?
- Idiomatic error handling?
- Changes internally consistent?
- Is logic isolated and composable?
- Are there existing tests if neccesary?

{"pass": bool, "issues": [...]}

4: Robustness (sonnet)

TASK: ${TASK}
DIFF: ${DIFF}

- Actually solves the problem?
- Edge cases: empty, null, zero, negative, boundaries, concurrency?
- Regression risk: changed signatures, shared state, removed exports?
- Maintains API contracts?

{"pass": bool, "issues": [...]}

5: Scope (haiku)

TASK: ${TASK}
FILES: ${FILES}
DIFF: ${DIFF}

- Solved the problem or just the symptom?
- Changes unrelated to task?
- Unnecessary refactoring?

{"pass": bool, "issues": [...]}

Results

Check Verdict Issues
Code Review โœ“/โœ— ...
Simplification โœ“/โœ— ...
Consistency โœ“/โœ— ...
Robustness โœ“/โœ— ...
Scope โœ“/โœ— ...

ALL PASS: Ready to commit.

ANY FAIL: List issues, fix them, run /qc again.

Same issue 3x: Escalate to user.

Notes

  • Invalid JSON? Retry once. Still broken? Mark fail.
  • Large diffs (>500 lines): run simplification file-by-file.

Source: SKILL.md on GitHub

No third-party reports yet.

Signed by skilld at e637554. This ties the file your Agent reads to that commit on GitHub. It does not review the instructions.

Last checked against GitHub yesterday.

Activeupdated 8 months ago
What it can do
Runs commands Reads files
All 5 allowed tools
TaskBashReadGrepGlob

README badge

README badge for macro-inc/macro/qc