Index of every page on this site: llms.txt
All skills
minimax-ai avatar

/engineering-review-feedback

@0db1b4f
by MiniMaxminimax-ai/mcode-stack736 stars
50
Run it yourself

Use when handling code review feedback as the change author, addressing reviewer comments, drafting replies, resolving disagreements, or summarizing updates. TRIGGER on "address review feedback", "respond to this review comment", "reviewer asked", "I disagree with reviewer", "what should I reply?", or "apply PR comments". If role is unclear, ask reviewer or author. DO NOT TRIGGER for reviewer comment writing, full code review, or PR descriptions unless author-response behavior is requested.

Use this Skill: https://skilld.dev/gh/minimax-ai/mcode-stack/engineering-review-feedback

Nothing lands on disk. Nothing to clean up.

Fork this Skill

Edit a local copy. It keeps the author and licence.

SKILL.md

≈131 tokens for metadata: the name and description. ≈965 when used: this file.

Description uses 6.6% of example budget

Before choosing a Skill, your Agent reads its name and description. All available Skills share that space.

  • A shorter description leaves more room for other Skills. This entry exceeds our 1% size suggestion.

In our Claude Code example, all Skill names and descriptions share 8,000 characters. This Skill uses ≈525 characters, or 6.6%.

The 1% threshold is a size suggestion. Longer descriptions can still fit.

Your model, settings, and other Skills decide how much text your Agent can read.

Example settings and source

The example uses a 200k-token context and default Claude Code settings. The count includes the name, description, separators, and when_to_use when present. Codex also counts local file paths.

Skit's source and limits: Codex 0.160.1, Claude Code 2.1.292.

Engineering Review Feedback

Handle reviewer feedback as collaboration toward better code. The best response often changes the code, tests, or comments so future readers benefit, rather than explaining only inside the review thread.

Adapted from Google Engineering Practices Documentation, especially "How to handle reviewer comments." Source: https://google.github.io/eng-practices/review/developer/handling-comments.html. License: CC-BY 3.0.

Response Workflow

  1. Pause before responding if the comment feels frustrating.
  2. Identify what the reviewer is asking for.
  3. Classify each comment:
    • Code change required.
    • Test change required.
    • Documentation or comment change required.
    • Clarification needed.
    • Disagreement to discuss.
    • Non-blocking suggestion.
  4. Prefer improving the artifact over explaining in the review tool.
  5. Run the relevant verification.
  6. Reply with what changed, why, and how it was tested.

If a reviewer says they do not understand the code, first try to make the code clearer. Add a code comment only when the why cannot be expressed cleanly in code.

When You Agree

Use a short response and make the change.

Done. I renamed the helper to describe normalization rather than validation and updated the two call sites.

Tested with: npm test -- user-profile.test.ts

When You Need Clarification

Ask for the missing decision or constraint. Avoid defensive wording.

I want to make sure I understand the concern. Are you asking for this to reject duplicate requests at the API boundary, or for the worker to make duplicate processing idempotent?

When You Disagree

Disagree by comparing tradeoffs, not by rejecting the person.

I chose X because it keeps the retry policy in one place and avoids a second queue state. My concern with Y is that it makes cancellation observable in two different layers.

If you think Y better serves the rollback requirement, I can switch to it. Is that the tradeoff you want prioritized?

If the reviewer provides better technical reasoning, accept it and adjust. If neither side can converge, move to a higher-bandwidth conversation and summarize the decision back in the review.

When Feedback Is Not Constructive

Do not reply in kind. Extract any technical concern that can be addressed in code, tests, or docs. If the comment is hostile, vague, or repeatedly unproductive, move to a private or higher-bandwidth conversation, involve a lead when needed, and summarize only the technical decision back in the review.

Fix the Right Place

  • Confusing expression: simplify or rename it.
  • Hidden invariant: encode it in types, validation, assertions, or a focused comment.
  • Missing behavior confidence: add or improve tests.
  • Missing context: update the PR description, code comment, README, or design doc.
  • Reviewer misunderstanding caused by stale diff: rebase, remove dead code, or update the description.
  • Pure preference: ask whether it is required; otherwise treat as optional.

Summary Reply Template

Addressed this round:
- Changed ...
- Added/updated tests for ...
- Clarified ...

Verification:
- `...`

Open:
- ...

Common Mistakes

  • Replying in anger or with sarcasm.
  • Explaining confusing code only in the review thread.
  • Treating every reviewer suggestion as mandatory without clarifying severity.
  • Saying "will clean up later" when the current change introduces the complexity.
  • Making broad unrelated refactors while addressing a narrow review comment.

Also published in agentara/skills (MIT, Copyright (c) 2026 agentara) by the same author. The content is adapted from Google Engineering Practices under CC-BY 3.0; see the source note above. Full notices: NOTICE.md.

Source: SKILL.md on GitHub

No rule matched.

skilld matched fixed text patterns in SKILL.md and file names. Patterns miss obfuscated code.

skilld run checks every file with the same patterns. It asks for approval before it loads a Skill with a behavior marked Needs approval.

1 warning23d3 checks · Risk SAFE
  • Gen Agent Trust Hub23d

    This skill provides best practices and templates for engineers to handle code review feedback. It consists entirely of instructional markdown and contains no executable code or security risks.

  • Socket23d

    No alerts

  • Snyk23d

    Risk: MEDIUM · 1 issue

Signed by skilld at 0db1b4f. This ties the file your Agent reads to that commit on GitHub. It does not review the instructions.

Last checked against GitHub last week.

Activeupdated 3 weeks ago

README badge

README badge for minimax-ai/mcode-stack/engineering-review-feedback