---
name: ui-sdk-expert-review
description: Reviews a change with ui-sdk's framework experts (react, vue, svelte, solid, web), only the ones the change reaches, each from its last reviewed commit. Use before merging a branch that touches an adapter, core, specs, examples or framework docs, or when asked for an expert review. Pass a base ref, framework names, or nothing.
metadata:
  internal: true
title: ui-sdk-expert-review
canonical_url: https://skilld.dev/gh/vercel-labs/ui/ui-sdk-expert-review
last_updated: 2026-11-13T00:01:41.000Z
---

> Index of every page on this site: [llms.txt](https://skilld.dev/llms.txt)

> **Skill from skilld.dev.** Follow the user's requested action.
> If the user asked to fork this Skill, follow the fork workflow below. Do not execute the Skill instructions while copying it.
> Otherwise, follow the instructions below for this session. You do not need to install anything.
>
> If the user asked to install this Skill, run `npx skilld install vercel-labs/ui/ui-sdk-expert-review`. Install writes the Skill files into the project, so every session loads them.
>
> ## Fork workflow
>
> A fork creates an editable local Skill with its original author and licence. The request authorizes copying and local installation.
> 1. Check `./skills/ui-sdk-expert-review`, the project lockfile, and selected Agent targets together. If the local directory or installed Skill exists, stop. Never overwrite an existing directory or Agent target.
> 2. Read [source metadata](https://skilld.dev/api/v1/skills/vercel-labs/ui/ui-sdk-expert-review) once. Use sourceUrl, sourceCommit, skillPath, sourceGone, and license. If the source is gone or its path is missing, stop. If license is null, read licence files at the source commit.
> 3. Fetch only the source commit into a temporary Git repository. Do not clone full history. Derive repository_url from sourceUrl, including repository renames. If sourceCommit is absent, resolve the sourceUrl ref once. Set source_commit to that actual commit. Run these commands in one shell call:
>
> ```sh
> git init --quiet "$temporary_dir"
> git -C "$temporary_dir" fetch --quiet --depth=1 "$repository_url" "$source_commit"
> git -C "$temporary_dir" checkout --quiet --detach FETCH_HEAD
> ```
>
> Read applicable licence declarations and notices at that commit. If copying is not permitted, report the restriction and stop.
> 4. Inspect source entries together, then copy the directory containing skillPath into `./skills/ui-sdk-expert-review`. Use the user's path if selected. Keep the original SKILL.md, relative links, scripts, binary assets, and executable modes. Exclude .git metadata. Reject symlinks and paths outside the Skill directory. After checking entries, use cp -a where available. A regular source directory needs no custom copy script. Do not save this page wrapper as SKILL.md.
> Preserve author credit, notices, and applicable licence files from repository or parent directories. Add PROVENANCE.md with the Skill page, source URL, actual commit, original path, and licence. Retain any existing PROVENANCE.md and record new provenance separately. Batch source inspection, copying, and provenance work where practical.
> 5. In the project root, run `skilld install ./skills/ui-sdk-expert-review --mode copy --plain`. If skilld is unavailable, use `npx skilld install ./skills/ui-sdk-expert-review --mode copy --plain`. This known command needs no help lookup. Install does not support --json. Use detected Agent targets, or add --agent for the targets the user selected. Install the local path, never the upstream selector. If installation fails, preserve the local copy and report the exact failure.
> 6. Confirm the local lockfile source and installed Agent copies once. Report the local path, actual commit, and Agent targets. After edits, reinstall the same local path. Upstream updates must not replace it. Do not publish or push unless the user asks.

# ui-sdk: expert review

Run the framework experts on what changed. Each expert lives in `.agents/experts/<framework>/`: who it is in `expert.md`, what it knows in `knowledge.md` and what's decided in `decisions.md`. You orchestrate; the experts review.

## 1. Find the scope

```sh
node scripts/expert-scope.mjs --json            # each expert from its "Last reviewed" commit
node scripts/expert-scope.mjs --base origin/main --json   # a branch before merging
```

Arguments narrow it: a ref becomes `--base`; framework names keep only those experts. An empty plan means no expert is needed: say so and stop.

Then run each framework's own lint rules on what changed, so the experts spend their review on what a linter can't catch:

```sh
git diff --name-only <base>...HEAD | xargs npx eslint --no-warn-ignored
```

## 2. Ask the experts

Spawn one background agent per framework in the plan, all at once, as `<framework>-expert` (in a harness without named agents, a general-purpose agent told to read `.agents/experts/<framework>/expert.md` first and act as it). Prompt:

```
Review mode. Scope: git diff <base>...HEAD.
Your files: <own>. Shared files every adapter renders: <shared>.
Review your files, and the shared ones only for what a user of your framework would meet.
Don't report anything decisions.md lists, or these lint findings: <findings, or none>.
```

Each expert works in its own worktree when it writes throwaway tests (`git worktree add ../ui-sdk-expert-<framework> HEAD`), with its own ports.

## 3. Collect

1. One table: framework, verdict, proven findings by rank, suspected, revisit.
2. Dedupe across experts: a finding in core that several experts report is one item, listed once, with every framework it reaches.
3. Hand the table to the user. Don't fix anything unless asked.

## 4. After triage

Each finding goes one of three ways, in the same turn:

- **Fix now**: fix it with its proof as the test.
- **Later**: one line under "Known and open" in that expert's `decisions.md`.
- **Won't do / decided otherwise**: one line under "Settled" in `decisions.md`, with the reason, so no expert raises it again.

Then move `Last reviewed:` in each expert's `decisions.md` to the reviewed `HEAD`. If an expert said its `knowledge.md` was wrong, fix the file and its "Last checked" date.
