Index of every page on this site: llms.txt
All skills
e2e-inc avatar

/ship-pr

@a5d1788
by e2ee2e-inc/e2e14k stars
782
Run it yourself

Take finished work in e2e-inc/e2e to a PR a human can review without fighting CI or bots - checks, verification against the built packages, a fresh-context self-review, the PR itself, then babysitting to the Ready for Human Review label. Use whenever you are asked to open, create, ship, or submit a PR, or when implementation is done and the next step is review.

Use this Skill: https://skilld.dev/gh/e2e-inc/e2e/ship-pr

Nothing lands on disk. Nothing to clean up.

Fork this Skill

Edit a local copy. It keeps the author and licence.

referencesreview-prompt.md

≈497 tokens on demand. Your agent reads this file only when SKILL.md points to it.

Fresh-context review prompt

Give this to a reviewer that has not seen the implementation conversation. Paste it with <base> filled in. The reviewer reads files itself; do not paste the diff or your own summary of it.


You are reviewing a change in e2e-inc/e2e before it becomes a PR. You did not write it. Assume it has bugs and find them.

  1. Read AGENTS.md. Its contracts, security invariants, and gotchas are hard rules.
  2. Read the diff: git fetch origin && git diff $(git merge-base origin/<base> HEAD) (committed and uncommitted changes to tracked files; a local <base> can be stale) and every untracked file git status lists. Open the surrounding code for every hunk; a hunk read alone hides its callers.
  3. Check the diff against every pattern in .dev/skills/babysit/references/review-triage.md under "Patterns reviewers keep catching here".
  4. Check the contracts: a public type, error code, CLI flag, or wire field that changed without its .d.ts review, sdk-types.ts assertion, schema and fixtures, reference/errors.mdx entry, docs page, skills/e2e/ text, or changeset.
  5. Check what agents leave behind: comments that narrate code, defensive checks or try/catch the call site does not need, as casts or any to silence types, dead code, a second way of doing something the codebase already does one way, hand-rolled retry or sleep, relative imports without .ts.
  6. Check the tests: would they fail if the change were reverted? A test that passes with every import stubbed proves nothing. An agentic assertion needs a paired deterministic check.

Report only findings you can defend with a concrete scenario. For each: file:line, severity (critical = wrong behavior, security, or a contract break; important = maintainability or a guardrail break; skip nits lint already catches), what breaks, the input or state that triggers it, and the fix. If you find nothing, say so; do not pad the list.

Source: SKILL.md on GitHub

skilld matched fixed text patterns in SKILL.md and file names. Patterns miss obfuscated code.

skilld run checks every file with the same patterns. It asks for approval before it loads a Skill with a behavior marked Needs approval.

No alerts1mo3 checks · Risk SAFE
  • Gen Agent Trust Hub1mo

    This skill implements a comprehensive workflow for shipping pull requests in the tester-army/e2e repository, covering testing, verification, and code review. It uses standard development tools like pnpm, git, and the GitHub CLI. A low-severity risk of indirect prompt injection exists because the skill processes arbitrary code changes, but this is addressed by instructing a fresh-context review session.

  • Socket1mo

    No alerts

  • Snyk1mo

    Risk: LOW · No issues

Signed by skilld at a5d1788. This ties the file your Agent reads to that commit on GitHub. It does not review the instructions.

Last checked against GitHub yesterday.

Activeupdated 2 weeks ago
metadata
{
  "internal": true
}

README badge

README badge for e2e-inc/e2e/ship-pr