Index of every page on this site: llms.txt
All skills
onmax avatar

/review-document

@aecfada
by Maxonmax/comark-ui43 stars
3
Run it yourself

Turns a review's findings into one short Markdown document a reader can act on, with the verdict first and each finding ranked, located, backed by evidence, and paired with its fix. Use when writing up a code review, a design or QA review, or an audit, where the reader must decide what to do about what you found.

Use this Skill: https://skilld.dev/gh/onmax/comark-ui/review-document

Nothing lands on disk. Nothing to clean up.

Fork this Skill

Edit a local copy. It keeps the author and licence.

referencesexample.md

≈444 tokens on demand. Your agent reads this file only when SKILL.md points to it.

Review: avatar cache

[!CAUTION] Request changes One blocking finding: after a large avatar loads, every smaller one on the page shows the large image. The fix is one line.

Reviewed acme/web#418 at 9f3c2e1.

1. Small avatars load the 512px image (blocking)

src/avatars/cache.ts:18. The cache key is the user's id alone, so once the profile header loads someone's 512px avatar, the 32px avatars in comments get the same file. Reproduced with a test:

::tests{title="pnpm test src/avatars"}

<testsuite name="cache.test.ts" time="0.18">
  <testcase classname="cache.test.ts" name="returns a cached avatar" time="0.01"/>
  <testcase classname="cache.test.ts" name="returns a 32px avatar after a 512px one" time="0.02">
    <failure message="expected 512 to be 32">AssertionError: expected 512 to be 32
    at cache.test.ts:27:31</failure>
  </testcase>
</testsuite>

::

::diff{line=18 label="Fix"}

const key = user.id;
const key = `${user.id}:${size}`;

::

2. The cache never evicts (should fix)

src/avatars/cache.ts:9. Read in the code, not measured: the map grows by one entry per user and size for as long as the tab stays open, which on the team directory is thousands of images.

const cache = new Map<string, Blob>();

Cap it, such as an LRU of 500 entries, or decide the tab's lifetime is short enough not to.

Checked

  • Ran pnpm test src/avatars: one failure, above.
  • Opened a profile on the preview at 1440px and watched the comment avatars after the header loaded.

Not checked

  • Server rendering: the cache only runs in the browser, and I didn't confirm the server skips it.
  • Safari's memory use.

Source: SKILL.md on GitHub

skilld matched fixed text patterns in SKILL.md and file names. Patterns miss obfuscated code.

skilld run checks every file with the same patterns. It asks for approval before it loads a Skill with a behavior marked Needs approval.

No alerts6d3 checks · Risk SAFE
  • Gen Agent Trust Hub8d

    This skill facilitates the creation of structured review documents and utilizes vendor-provided tools for linting. It is generally secure but possesses an indirect prompt injection surface from processed review findings.

  • Socket6d

    No alerts

  • Snyk8d

    Risk: LOW · No issues

Signed by skilld at aecfada. This ties the file your Agent reads to that commit on GitHub. It does not review the instructions.

Last checked against GitHub yesterday.

Activeupdated 2 weeks ago

README badge

README badge for onmax/comark-ui/review-document