All skills
vercel-labs avatar

/vercel-react-best-practices

@805687f
by Vercel Labsvercel-labs/openreview1.7k stars
118

React and Next.js performance optimization guidelines from Vercel Engineering. This skill should be used when writing, reviewing, or refactoring React/Next.js code to ensure optimal performance patterns. Triggers on tasks involving React components, Next.js pages, data fetching, bundle optimization, or performance improvements.

Use this Skill: https://skilld.dev/gh/vercel-labs/openreview/vercel-react-best-practices

This session only. Nothing lands on disk.

rulesrerender-functional-setstate.md

≈747 tokens on demand. Your agent reads this file only when SKILL.md points to it.

Use Functional setState Updates

When updating state based on the current state value, use the functional update form of setState instead of directly referencing the state variable. This prevents stale closures, eliminates unnecessary dependencies, and creates stable callback references.

Incorrect (requires state as dependency):

function TodoList() {
  const [items, setItems] = useState(initialItems);

  // Callback must depend on items, recreated on every items change
  const addItems = useCallback(
    (newItems: Item[]) => {
      setItems([...items, ...newItems]);
    },
    [items]
  ); // ❌ items dependency causes recreations

  // Risk of stale closure if dependency is forgotten
  const removeItem = useCallback((id: string) => {
    setItems(items.filter((item) => item.id !== id));
  }, []); // ❌ Missing items dependency - will use stale items!

  return <ItemsEditor items={items} onAdd={addItems} onRemove={removeItem} />;
}

The first callback is recreated every time items changes, which can cause child components to re-render unnecessarily. The second callback has a stale closure bug—it will always reference the initial items value.

Correct (stable callbacks, no stale closures):

function TodoList() {
  const [items, setItems] = useState(initialItems);

  // Stable callback, never recreated
  const addItems = useCallback((newItems: Item[]) => {
    setItems((curr) => [...curr, ...newItems]);
  }, []); // ✅ No dependencies needed

  // Always uses latest state, no stale closure risk
  const removeItem = useCallback((id: string) => {
    setItems((curr) => curr.filter((item) => item.id !== id));
  }, []); // ✅ Safe and stable

  return <ItemsEditor items={items} onAdd={addItems} onRemove={removeItem} />;
}

Benefits:

  1. Stable callback references - Callbacks don't need to be recreated when state changes
  2. No stale closures - Always operates on the latest state value
  3. Fewer dependencies - Simplifies dependency arrays and reduces memory leaks
  4. Prevents bugs - Eliminates the most common source of React closure bugs

When to use functional updates:

  • Any setState that depends on the current state value
  • Inside useCallback/useMemo when state is needed
  • Event handlers that reference state
  • Async operations that update state

When direct updates are fine:

  • Setting state to a static value: setCount(0)
  • Setting state from props/arguments only: setName(newName)
  • State doesn't depend on previous value

Note: If your project has React Compiler enabled, the compiler can automatically optimize some cases, but functional updates are still recommended for correctness and to prevent stale closure bugs.

Source: SKILL.md on GitHub

No alerts17d4 checks · Risk SAFE
  • Gen Agent Trust Hub17d

    This skill provides rules, tools, and scripts intended for compiling and managing React and Next.js performance optimization guidelines. No high-severity security considerations or anomalous patterns were discovered.

  • Socket17d

    No alerts

  • Snyk17d

    Risk: LOW · No issues

  • Runlayer6mo

    1/61 files flagged

Signed by skilld at 805687f. This ties the file your Agent reads to that commit on GitHub. It does not review the instructions.

Last checked against GitHub 2 months ago.

Dormantupdated 7 months ago
metadata
{
  "author": "vercel",
  "version": "1.0.0"
}
  • React
  • Performance
  • next.js
  • optimization
  • bundle-size
  • server-components
  • data-fetching
  • rendering
  • javascript

README badge

README badge for vercel-labs/openreview/vercel-react-best-practices

Provides 58 prioritized React and Next.js performance rules from Vercel Engineering, organized across waterfalls, bundle size, server/client data fetching, re-renders, and rendering patterns. Use when writing or refactoring React components and Next.js pages to apply production-grade optimization practices.

Generated from the current SKILL.md.

Does this skill apply to both React and Next.js?
Yes. The skill covers React components, Next.js pages, server components, server actions, and data fetching patterns for both frameworks.
Can I use this skill to review existing code for performance issues?
Yes. The skill is designed for reviewing and refactoring React/Next.js code against 58 prioritized rules organized by impact (critical, high, medium, low).
Does this skill cover bundle size optimization?
Yes. Bundle size optimization is marked as a critical priority category with 5 rules, including barrel imports, dynamic imports, and third-party script deferral.
What about server-side performance and data fetching?
The skill covers both. It includes rules for server components, React.cache(), LRU caching, parallel fetching, and client-side patterns like SWR deduplication and event listener optimization.

Generated from the current SKILL.md. These answers refresh after source changes.