Index of every page on this site: llms.txt
All skills
wshobson avatar

/code-review-excellence

@4220308
by Seth Hobsonwshobson/agents43k stars
4,518
Run it yourself

Master effective code review practices to provide constructive feedback, catch bugs early, and foster knowledge sharing while maintaining team morale. Use when reviewing pull requests, establishing review standards, or mentoring developers.

Use this Skill: https://skilld.dev/gh/wshobson/agents/code-review-excellence

Nothing lands on disk. Nothing to clean up.

Fork this Skill

Edit a local copy. It keeps the author and licence.

referencesreview-techniques.md

≈548 tokens on demand. Your agent reads this file only when SKILL.md points to it.

Review Techniques

Technique 1: The Checklist Method

## Security Checklist

- [ ] User input validated and sanitized
- [ ] SQL queries use parameterization
- [ ] Authentication/authorization checked
- [ ] Secrets not hardcoded
- [ ] Error messages don't leak info

## Performance Checklist

- [ ] No N+1 queries
- [ ] Database queries indexed
- [ ] Large lists paginated
- [ ] Expensive operations cached
- [ ] No blocking I/O in hot paths

## Testing Checklist

- [ ] Happy path tested
- [ ] Edge cases covered
- [ ] Error cases tested
- [ ] Test names are descriptive
- [ ] Tests are deterministic

Technique 2: The Question Approach

Instead of stating problems, ask questions to encourage thinking:

❌ "This will fail if the list is empty."
✅ "What happens if `items` is an empty array?"

❌ "You need error handling here."
✅ "How should this behave if the API call fails?"

❌ "This is inefficient."
✅ "I see this loops through all users. Have we considered
the performance impact with 100k users?"

Technique 3: Suggest, Don't Command

## Use Collaborative Language

❌ "You must change this to use async/await"
✅ "Suggestion: async/await might make this more readable:
```typescript
    async function fetchUser(id: string) {
        const user = await db.query('SELECT * FROM users WHERE id = ?', id);
        return user;
    }
```
What do you think?"

❌ "Extract this into a function"
✅ "This logic appears in 3 places. Would it make sense to
extract it into a shared utility function?"

Technique 4: Differentiate Severity

Use labels to indicate priority:

🔴 [blocking] - Must fix before merge
🟡 [important] - Should fix, discuss if disagree
🟢 [nit] - Nice to have, not blocking
💡 [suggestion] - Alternative approach to consider
📚 [learning] - Educational comment, no action needed
🎉 [praise] - Good work, keep it up!

Example:
"🔴 [blocking] This SQL query is vulnerable to injection.
Please use parameterized queries."

"🟢 [nit] Consider renaming `data` to `userData` for clarity."

"🎉 [praise] Excellent test coverage! This will catch edge cases."

Source: SKILL.md on GitHub

No rule matched.

skilld matched fixed text patterns in SKILL.md and file names. Patterns miss obfuscated code.

skilld run checks every file with the same patterns. It asks for approval before it loads a Skill with a behavior marked Needs approval.

No alerts1mo5 checks · Risk SAFE
  • Gen Agent Trust Hub1mo

    This skill is an educational resource providing best practices, checklists, and techniques for conducting effective code reviews. It contains no executable code, network operations, or sensitive data access.

  • Socket1mo

    No alerts

  • Snyk1mo

    Risk: LOW · No issues

  • Runlayer8mo

    1 file scanned · No issues

  • ZeroLeaks7mo

    Score: 93/100 · 2 sections analyzed

Signed by skilld at 4220308. This ties the file your Agent reads to that commit on GitHub. It does not review the instructions.

Last checked against GitHub 3 days ago.

Activeupdated last month
  • code-review
  • pull-requests
  • feedback
  • mentoring
  • best-practices
  • team-collaboration
  • quality-assurance
  • architecture-review

README badge

README badge for wshobson/agents/code-review-excellence

Provides methods and frameworks for conducting effective code reviews: giving constructive feedback, catching bugs and security issues, organizing review processes by phase, and handling difficult feedback or disagreements. Covers language-specific patterns for Python and TypeScript, review checklists, and techniques for architectural and security reviews.

Generated from the current SKILL.md.

Does this skill apply to all programming languages?
The skill covers general review principles applicable to any language, with detailed examples for Python and TypeScript/JavaScript. The core techniques (checklist method, question approach, severity labeling) work across all languages.
What's the recommended PR size for review?
The skill recommends 200-400 lines max per PR for effective review. PRs larger than 400 lines should be asked to split into smaller changes.
Does this cover security code reviews?
Yes. The skill includes a dedicated security review checklist covering authentication, authorization, input validation, data protection, and common vulnerabilities like SQL injection and XSS.
How should I structure feedback when reviewing code?
The skill recommends using severity labels (blocking, important, nit, suggestion, learning, praise) and the question approach rather than commands, paired with specific, actionable suggestions tied to concrete problems.
What should I focus on and what should automated tools handle?
Focus on logic correctness, security, performance, design fit, and testing quality. Don't manually review formatting, imports, linting violations, or typos—use Prettier, Black, and linters for those.

Generated from the current SKILL.md. These answers refresh after source changes.